Add new building blocks. #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a |
sammachin
approved these changes
May 1, 2018
tbedford
changed the title
added 6 commits
May 2, 2018 12:22
judy2k
suggested changes
May 21, 2018
.gitignore
Outdated
| private.key | ||
| *.key |
There was a problem hiding this comment.
no big deal, but *.key and private.key overlap :)
| ) | ||
|
|
||
| response = client.update_call(UUID, action="earmuff") | ||
| pprint(response) |
voice/record-a-call.py
Outdated
| def recordings(): | ||
| data = request.get_json() | ||
| pprint(data) | ||
| return ("200") |
There was a problem hiding this comment.
I feel this is confusing, for a few reasons:
- The parentheses aren't needed, and imply a tuple (which it isn't because it would need a trailing comma)
- The string
"200"will be converted to the body of the response, but it looks like the HTTP status code. - The HTTP 200 status code is implicit :)
I'm not sure what content would actually be useful, given that it's ignored by Nexmo's servers, but something more informative like the following may be more clear:
return "Webhook received"
voice/record-a-conversation.py
Outdated
| def recordings(): | ||
| data = request.get_json() | ||
| pprint(data) | ||
| return ("200") |
|
|
||
| NOW = datetime.utcnow() | ||
| DATE_END = NOW.replace(microsecond=0).isoformat()+"Z" | ||
| DATE_START = (NOW - timedelta(hours=24, minutes=00)).replace(microsecond=0).isoformat()+"Z" |
voice/retrieve-info-for-all-calls.py
Outdated
| DATE_START = (NOW - timedelta(hours=24, minutes=00)).replace(microsecond=0).isoformat()+"Z" | ||
|
|
||
| params = {"date_start": DATE_START, "date_end": DATE_END} | ||
| response = client.get_calls(params) |
There was a problem hiding this comment.
These two lines could just be:
response = client.get_calls(date_start=DATE_START, date_end=DATE_END)... which would be more consistent with the calling conventions above - but ultimately I'm not bothered too much.
judy2k
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the code for the 'connect an inbound call' building block. Hopefully it's the format you require.